Login

Template tag for importing content from external url

Author:
dchandek
Posted:
April 23, 2008
Language:
Python
Version:
.96
Score:
1 (after 1 ratings)

Usage:

Literal value, use default timeout {% geturl "http://example.com/path/to/content/" %}

Variable value, literal timeout {% geturl object.urlfield 5 %} 

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
@register.simple_tag
def geturl(url, timeout=None):
    """
    Usage: {% geturl url [timeout] %}

    Examples:
    {% geturl "http://example.com/path/to/content/" %}
    {% geturl object.urlfield 1 %} 
    """
    import socket
    from urllib2 import urlopen
    socket_default_timeout = socket.getdefaulttimeout()
    if timeout is not None:
        try:
            socket_timeout = float(timeout)
        except ValueError:
            raise template.TemplateSyntaxError, "timeout argument of geturl tag, if provided, must be convertible to a float"
        try:
            socket.setdefaulttimeout(socket_timeout)
        except ValueError:
            raise template.TemplateSyntaxError, "timeout argument of geturl tag, if provided, cannot be less than zero"
    try:
        try: 
            content = urlopen(url).read()
        finally: # reset socket timeout
            if timeout is not None:
                socket.setdefaulttimeout(socket_default_timeout) 
    except:
        content = ''        
    return content

More like this

  1. Template tag - list punctuation for a list of items by shapiromatron 3 months, 1 week ago
  2. JSONRequestMiddleware adds a .json() method to your HttpRequests by cdcarter 3 months, 2 weeks ago
  3. Serializer factory with Django Rest Framework by julio 10 months, 1 week ago
  4. Image compression before saving the new model / work with JPG, PNG by Schleidens 11 months ago
  5. Help text hyperlinks by sa2812 11 months, 3 weeks ago

Comments

kioopi (on April 24, 2008):

This screams xss-vulnerability. Do you have control over the urls you include?

#

dchandek (on April 24, 2008):

The intention is similar to the <c:import/> tag of the JavaServer Pages Standard Tag Library (JSTL). It's up to the developer to use trusted sources. :)

#

dchandek (on April 24, 2008):

Updated to use template.Variable class from Django dev version. Also switched to urllib2 b/c urllib2.urlopen raises urllib2.HTTPError on 404, whereas urllib.urlopen simply returns 404 page content (bad).

#

dchandek (on April 24, 2008):

Updated to use the simple_tag shortcut. :)

#

cmheisel (on April 24, 2008):

If you use this in production there are a few things to be wary of (we've done something similar for trusted URLs at my job).

  • You'll want to set a timetout so slow servers don't hold up your page
  • You'll want some (serious) caching

From what I can tell, the way to set a timeout is: import socket; socket.setdefaulttimeout(seconds)

#

dchandek (on April 24, 2008):

Good point on the timeout issue. Caching, of course, can be handled using the {% cache %} template tag.

#

dchandek (on April 24, 2008):

Updated to deal with timeout issue. I have a minimal understanding of sockets and threads, so I played it safe by getting current default socket timeout at the outset and resetting the default at the end.

#

Please login first before commenting.